Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solve issue #2374 (NoSuchMethodError) #2375

Closed
wants to merge 1 commit into from
Closed

solve issue #2374 (NoSuchMethodError) #2375

wants to merge 1 commit into from

Conversation

stephengold
Copy link
Member

This restores the pre-PR #2231 API of AnimComposer, in order to improve compatibility with JME 3.7 .

It then adds the 2 new methods (which return objects) under different names, to provide the functionality desired by @capdevon.

@stephengold stephengold added the defect Something that is supposed to work, but doesn't. Less severe than a "bug" label Feb 19, 2025
@stephengold stephengold linked an issue Feb 19, 2025 that may be closed by this pull request
NoSuchMethodError AnimComposer.makeLayer() #2374
Closed
@yaRnMcDonuts
Copy link
Member

This looks like a good solution to me.

@capdevon
Copy link
Contributor

capdevon commented Feb 19, 2025 •
edited
Loading

Hi everyone,
Thank you for identifying the backwards compatibility issue and for all your hard work. While Stephen's PR offers a great solution to preserve my proposal, adding two more methods might lead to confusion and increased maintenance in the future.
Given that my PR isn't crucial and may cause more issues than benefits, I believe the best solution in this case is to discard this PR and my PR and restores the pre-PR #2231 API of AnimComposer.
I appreciate your understanding and time. Let's continue working together to make the jme engine even better!

@stephengold
Copy link
Member Author

@capdevon thanks for your perspective and insight

@yaRnMcDonuts yaRnMcDonuts mentioned this pull request Feb 20, 2025
Merged
@yaRnMcDonuts
Copy link
Member

I'll go ahead and close this PR, and I've created a separate PR that reverts the changes in the original PR that caused the regression

@stephengold stephengold deleted the sgold/issue/2374 branch February 20, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
defect Something that is supposed to work, but doesn't. Less severe than a "bug"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NoSuchMethodError AnimComposer.makeLayer()
3 participants
@stephengold @yaRnMcDonuts @capdevon